Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention std::fs::remove_dir_all in std::fs::remove_dir #133183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n0toose
Copy link

@n0toose n0toose commented Nov 18, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 18, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joboet (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 18, 2024
@n0toose
Copy link
Author

n0toose commented Nov 18, 2024

P.S. I also plan to send an improvement for std::fs::remove_dir_all later, but I'm sending this as a first step (given that it's a first contribution) to see whether I've gotten the hang of the writing style.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@n0toose
Copy link
Author

n0toose commented Nov 18, 2024

third time's the charm?

@joboet
Copy link
Member

joboet commented Nov 19, 2024

Thank you, the new documentation is much better!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 19, 2024

📌 Commit 7bffa31 has been approved by joboet

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants