Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rustc --explain compatible with BusyBox less #133196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omnivagant
Copy link

busybox less does not support the -r flag and less(1) says:

USE OF THE -r OPTION IS NOT RECOMMENDED.

busybox less does not support the -r flag and less(1) says:

  USE OF THE -r OPTION IS NOT RECOMMENDED.
@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nnethercote (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 19, 2024
@workingjubilee workingjubilee changed the title Make rustc --explain busybox less compatible Make rustc --explain compatible with BusyBox less Nov 19, 2024
@nnethercote
Copy link
Contributor

USE OF THE -r OPTION IS NOT RECOMMENDED.

I see this text in the man page for GNU less, which is used on my Linux machine (unsurprising) and on my Mac laptop (huh?)

less is used as the pager on non-Windows sytems if PAGER isn't set. I guess the question is whether any versions of less (other than busybox's) have -R/-r that don't mean the same things as the GNU version.

https://man.freebsd.org/cgi/man.cgi?query=less shows that freebsd less is also the GNU one. Maybe that explains my Mac result above? Similar story with openbsd: https://man.openbsd.org/less.1. And netbsd: https://man.netbsd.org/less.1.

So, changing to -R seems ok for a lot of the popular non-Windows platforms, and fixes busybox, but I'm worried that I might be overlooking some other platform. Any suggestions how to overcome that worry?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants