Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore an occasionally-failing test in Miri #133200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ignore an occasionally-failing test in Miri #133200

wants to merge 1 commit into from
+3 −0

Conversation

RalfJung
Copy link
Member

This is like #128640, the test sometimes fails due to #121950.

@rustbot
Copy link
Collaborator

rustbot commented Nov 19, 2024

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 19, 2024
@RalfJung RalfJung mentioned this pull request Nov 19, 2024
Closed
@tgross35
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Nov 19, 2024

📌 Commit 7931a8d has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 19, 2024
@matthiaskrgr
Rollup merge of rust-lang#133200 - RalfJung:miri-rwlock-test, r=tgross35
9aac15d 
ignore an occasionally-failing test in Miri

This is like rust-lang#128640, the test [sometimes](rust-lang#133189) fails due to rust-lang#121950.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 19, 2024
Open
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 19, 2024
@bors
Auto merge of rust-lang#133205 - matthiaskrgr:rollup-xhhhp5u, r=matth…
be7ec27 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131081 (Use `ConstArgKind::Path` for all single-segment paths, not just params under `min_generic_const_args`)
 - rust-lang#132577 (Report the `unexpected_cfgs` lint in external macros)
 - rust-lang#133023 (Merge `-Zhir-stats` into `-Zinput-stats`)
 - rust-lang#133200 (ignore an occasionally-failing test in Miri)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @rustbot @tgross35 @bors