Also emit ICE dump files on stable rustc #133209
Draft
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf. <rust-lang#132245> where originally we made it nightly-only in case there was some problems with the ICE dumping infra breaking stable users. However, a good amount of time has since passed and such bugs have not materialized. It was also waiting for cargo gc work, but the timeline of that is unclear. Also note that ICE dumping is already perma-unstable behavior, so if this somehow is problematic it is very easy to revert.
It was only flaky for i686-mingw (windows-gnu), it seemed reasonably reliable for msvc.
This comment was marked as outdated.
This comment was marked as outdated.
rustbot
added
A-run-make
|
r? @estebank (or wg-diagnostics or compiler) |
jieyouxu
added
S-waiting-on-MCP
3 tasks
jieyouxu
added
the
S-blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLOCKED: waiting on MCP rust-lang/compiler-team#809
See On nightly, dump ICE backtraces to disk #108714 where originally we made it nightly-only in case there was some problems with the ICE dumping infra breaking stable users. However, a good amount of time has since passed (Jun 2023 when #108714 was merged vs Nov 2024 when this PR ws opened). It was waiting for cargo gc work, but the timeline of that is unclear so imo should not block this.
Also note that ICE dumping is perma-unstable behavior, so if this somehow is problematic it is very easy to revert.
This
run-maketest was flaky on windows-gnu but not msvc cc #128911.Closes #132245.
Unresolved concerns