Implement `use` associated items of traits #134754

frank-king · 2024-12-25T06:56:21Z

This PR implements #134691.

rustbot · 2024-12-25T06:56:29Z

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler/rustc_resolve/src/ident.rs

jieyouxu · 2024-12-25T07:32:13Z

cc @petrochenkov as this PR has some non-trivial resolve changes.

compiler/rustc_resolve/src/errors.rs

compiler/rustc_resolve/src/imports.rs

compiler/rustc_resolve/src/diagnostics.rs

tests/ui/resolve/associated-fn-called-as-fn.rs

compiler/rustc_resolve/src/diagnostics.rs

rustbot · 2025-01-16T08:32:53Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @rust-lang/wg-const-eval

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

The Miri subtree was changed

cc @rust-lang/miri

oli-obk · 2025-01-16T09:06:14Z

@bors r+

bors · 2025-01-16T09:06:17Z

📌 Commit 5079acc has been approved by oli-obk

It is now in the queue for this repository.

…sociated_functions, r=oli-obk Implement `use` associated items of traits This PR implements rust-lang#134691.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#133720 ([cfg_match] Adjust syntax) - rust-lang#134496 (Update documentation for Arc::from_raw, Arc::increment_strong_count, and Arc::decrement_strong_count to clarify allocator requirement) - rust-lang#134754 (Implement `use` associated items of traits) - rust-lang#135249 (Fix overflows in the implementation of `overflowing_literals` lint's help) - rust-lang#135251 (Only treat plain literal patterns as short) - rust-lang#135556 (Clarify note in `std::sync::LazyLock` example) - rust-lang#135560 (Update `compiler-builtins` to 0.1.144) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-01-16T14:37:23Z

@bors r- #135576 (comment)

fmease · 2025-01-16T15:55:45Z

Hmm, I'm pretty sure that failure is due to #135560 instead.

@bors r=oli-obk

bors · 2025-01-16T15:55:48Z

📌 Commit 5079acc has been approved by oli-obk

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134754 (Implement `use` associated items of traits) - rust-lang#135481 (coverage: Completely overhaul counter assignment, using node-flow graphs) - rust-lang#135504 (Allow coercing safe-to-call target_feature functions to safe fn pointers) - rust-lang#135561 (Update docs for `-Clink-dead-code` to discourage its use) - rust-lang#135574 (ci: mirror ubuntu:22.04 to ghcr.io) - rust-lang#135585 (resolve symlinks of LLVM tool binaries before copying them) - rust-lang#135588 (Add license-metadata.json to rustc-src tarball.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#134754 - frank-king:feature/import_trait_associated_functions, r=oli-obk Implement `use` associated items of traits This PR implements rust-lang#134691.

unstable book: document import_trait_associated_functions Documents rust-lang#134691 which was implemented in rust-lang#134754

Rollup merge of rust-lang#139149 - mejrs:itaf, r=ehuss unstable book: document import_trait_associated_functions Documents rust-lang#134691 which was implemented in rust-lang#134754

resolve: Support imports of associated types and glob imports from traits Follow up to rust-lang#134754, part of rust-lang#134691. This PR also closes rust-lang#138711 now. Prohibiting `use Trait::AssocType;` at name resolution stage doesn't make sense, the name itself is perfectly resolveable. It's a type checker's problem that the necessary generic args are not passed when the imported `AssocType` is used, so an error should be reported there. And since we can import associated trait items now, glob imports from traits can also be allowed.

Rollup merge of rust-lang#138712 - petrochenkov:impasst, r=fmease resolve: Support imports of associated types and glob imports from traits Follow up to rust-lang#134754, part of rust-lang#134691. This PR also closes rust-lang#138711 now. Prohibiting `use Trait::AssocType;` at name resolution stage doesn't make sense, the name itself is perfectly resolveable. It's a type checker's problem that the necessary generic args are not passed when the imported `AssocType` is used, so an error should be reported there. And since we can import associated trait items now, glob imports from traits can also be allowed.

rustbot assigned oli-obk Dec 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2024

frank-king commented Dec 25, 2024

View reviewed changes

compiler/rustc_resolve/src/ident.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

frank-king force-pushed the feature/import_trait_associated_functions branch from dc2bdee to 6905a19 Compare December 25, 2024 08:20

petrochenkov self-assigned this Dec 25, 2024

fmease reviewed Dec 25, 2024

View reviewed changes

compiler/rustc_resolve/src/errors.rs Show resolved Hide resolved

This comment has been minimized.

Sign in to view

fmease reviewed Dec 25, 2024

View reviewed changes

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

frank-king force-pushed the feature/import_trait_associated_functions branch 2 times, most recently from 8606eb3 to 72bc889 Compare December 25, 2024 15:16

oli-obk reviewed Jan 7, 2025

View reviewed changes

compiler/rustc_resolve/src/imports.rs Outdated Show resolved Hide resolved

frank-king force-pushed the feature/import_trait_associated_functions branch 2 times, most recently from d79e0e1 to 2427364 Compare January 15, 2025 14:51

frank-king commented Jan 16, 2025

View reviewed changes

compiler/rustc_resolve/src/diagnostics.rs Show resolved Hide resolved

oli-obk requested changes Jan 16, 2025

View reviewed changes

tests/ui/resolve/associated-fn-called-as-fn.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/diagnostics.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 16, 2025

frank-king force-pushed the feature/import_trait_associated_functions branch from 39b3949 to e249e6c Compare January 16, 2025 08:32

Implement use associated items of traits

5079acc

frank-king force-pushed the feature/import_trait_associated_functions branch from e249e6c to 5079acc Compare January 16, 2025 08:34

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 16, 2025

Rollup merge of rust-lang#134754 - frank-king:feature/import_trait_as…

7dce295

…sociated_functions, r=oli-obk Implement `use` associated items of traits This PR implements rust-lang#134691.

matthiaskrgr mentioned this pull request Jan 16, 2025

Rollup of 7 pull requests #135576

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 16, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 16, 2025

matthiaskrgr mentioned this pull request Jan 16, 2025

Rollup of 7 pull requests #135592

Merged

bors merged commit 62d0f45 into rust-lang:master Jan 17, 2025
6 checks passed

rustbot added this to the 1.86.0 milestone Jan 17, 2025

matthiaskrgr mentioned this pull request Jan 17, 2025

ICE: unexpected resolution for an identifier in pattern #135614

Closed

This was referenced Mar 19, 2025

import_trait_associated_functions is not very compatible with min_generic_const_args #138711

Closed

resolve: Support imports of associated types and glob imports from traits #138712

Merged

mejrs mentioned this pull request Mar 30, 2025

unstable book: document import_trait_associated_functions #139149

Merged

cramertj mentioned this pull request Apr 1, 2025

Tracking Issue for RFC 3591: useing associated items from traits #134691

Open

4 tasks

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Apr 3, 2025

Rollup merge of rust-lang#139149 - mejrs:itaf, r=ehuss

2f34cdd

unstable book: document import_trait_associated_functions Documents rust-lang#134691 which was implemented in rust-lang#134754

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 3, 2025

Rollup merge of rust-lang#139149 - mejrs:itaf, r=ehuss

ee56188

unstable book: document import_trait_associated_functions Documents rust-lang#134691 which was implemented in rust-lang#134754

fmease added the F-import_trait_associated_functions `#![feature(import_trait_associated_functions)]` label Oct 22, 2025

Implement use associated items of traits #134754

Implement use associated items of traits #134754

Uh oh!

Conversation

frank-king commented Dec 25, 2024

Uh oh!

rustbot commented Dec 25, 2024

Uh oh!

Uh oh!

This comment has been minimized.

jieyouxu commented Dec 25, 2024

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jan 16, 2025

Uh oh!

oli-obk commented Jan 16, 2025

Uh oh!

bors commented Jan 16, 2025

Uh oh!

matthiaskrgr commented Jan 16, 2025

Uh oh!

fmease commented Jan 16, 2025

Uh oh!

bors commented Jan 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Implement `use` associated items of traits #134754

Implement `use` associated items of traits #134754