Implement use associated items of traits
#134754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
frank-king
commented
Dec 25, 2024
This comment has been minimized.
This comment has been minimized.
|
cc @petrochenkov as this PR has some non-trivial resolve changes. |
frank-king
force-pushed
the
feature/import_trait_associated_functions
branch
from
dc2bdee to
6905a19
Compare
fmease
reviewed
Dec 25, 2024
This comment has been minimized.
This comment has been minimized.
fmease
reviewed
Dec 25, 2024
frank-king
force-pushed
the
feature/import_trait_associated_functions
branch
from
6905a19 to
8606eb3
Compare
frank-king
force-pushed
the
feature/import_trait_associated_functions
branch
from
8606eb3 to
72bc889
Compare
oli-obk
reviewed
Jan 7, 2025
Comment on lines
-831
to
+836
| Ok(binding) if binding.is_importable() => { | ||
| Ok(binding) | ||
| if binding.is_importable() | ||
| || binding.is_assoc_const_or_fn() | ||
| && this.tcx.features().import_trait_associated_functions() => | ||
| { |
There was a problem hiding this comment.
I think is_importable should just stop rejecting assoc const and fn. Instead, within this match arm, emit the feature error unconditionally if it is either of those two (and the feature wasn't enabled). That's how we handle feature gating where possible/feasible: just go through as if the feature gate was already enabled, but emit an error if it wasn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #134691.