Skip to content

Explore adding a reproducibility test to rust test infrastructure. #139793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

biabbas
Copy link
Contributor

@biabbas biabbas commented Apr 14, 2025

Fixes #75362
Trying to add a reproducibility check on rust infrastructure itself to detect reproducibility issues.
These were the issues encountered till now:
`. On ci only nightly build is supported because of an issue here: https://github.com/rust-lang/rust/blob/master/src/build_helper/src/git.rs#L143
2. Because this is a nightly build, llvm is built from sources. So space was an issue. This was resolved by deleting the copy of source and all build contents except for stage1 artifacts.
Questions:

  1. The check takes about 4hours to complete for now. Is this sustainable for each pr?
  2. Can we add this as a post merge workflow?
    This is also related to issue: Rust reproducibility issue - Finding the proper fix #134589

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2025

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 14, 2025
@biabbas biabbas force-pushed the reproducible branch 3 times, most recently from e5f3dfb to 95d3d7e Compare April 15, 2025 04:16
@biabbas biabbas force-pushed the reproducible branch 3 times, most recently from fe3b2c7 to 35d08c2 Compare April 15, 2025 09:06
@biabbas biabbas force-pushed the reproducible branch 2 times, most recently from 238555f to 916f799 Compare April 16, 2025 04:04
@biabbas biabbas force-pushed the reproducible branch 4 times, most recently from 4272cba to cfc6ce8 Compare April 17, 2025 06:35
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 18, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI for deterministic / reproducible builds
4 participants