Disable combining LLD with external llvm-config #139853

Kobzol · 2025-04-15T08:44:42Z

When an external llvm-config is used, we don't really know anything about the external LLD, as we don't build it ourselves. Therefore, we probably shouldn't allow using rust-lld nor copy it to the target sysroot.

Fixes: #139477

CC @cuviper

r? @onur-ozkan

try-job: dist-x86_64-linux
try-job: dist-aarch64-linux

rustbot · 2025-04-15T08:44:48Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

onur-ozkan

r=me with/without the nit once CI is green

onur-ozkan · 2025-04-15T09:00:50Z

src/bootstrap/src/core/config/config.rs

@@ -2397,6 +2397,15 @@ impl Config {
            );
        }

+        let has_external_llvm_config = !config.llvm_from_ci


Nit: We could move Builder::is_system_llvm to Config since it doesn't rely on any Builder specific data (other than is_builder_target function which can also be moved).

I don't feel very comfortable calling Config functions in Config::parse, because it's essentially its constructor, and some of the attributes used in the functions might not be initialized properly yet when the function is called. That being said, we access specific properties on the config variable anyway, so that's probably not so different. Moved the functions.

rustbot · 2025-04-15T10:16:36Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

Kobzol · 2025-04-15T10:16:39Z

@rustbot ready

…uilder` to `Config`

onur-ozkan · 2025-04-15T15:56:10Z

@bors r+

bors · 2025-04-15T15:56:13Z

📌 Commit 689b4c9 has been approved by onur-ozkan

It is now in the queue for this repository.

Disable combining LLD with external llvm-config When an external `llvm-config` is used, we don't really know anything about the external LLD, as we don't build it ourselves. Therefore, we probably shouldn't allow using `rust-lld` nor copy it to the target sysroot. Fixes: rust-lang#139477 CC `@cuviper` r? `@onur-ozkan`

Rollup of 8 pull requests Successful merges: - rust-lang#136926 (Stabilize `-Zdwarf-version` as `-Cdwarf-version`) - rust-lang#139647 (Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options) - rust-lang#139853 (Disable combining LLD with external llvm-config) - rust-lang#139867 (Fix some tidy paper cuts) - rust-lang#139871 (Fix wrong "move keyword" suggestion for async gen block) - rust-lang#139880 (Don't compute name of associated item if it's an RPITIT) - rust-lang#139884 (Update books) - rust-lang#139886 (`borrowck_graphviz_*` attribute tweaks) r? `@ghost` `@rustbot` modify labels: rollup

Disable combining LLD with external llvm-config When an external `llvm-config` is used, we don't really know anything about the external LLD, as we don't build it ourselves. Therefore, we probably shouldn't allow using `rust-lld` nor copy it to the target sysroot. Fixes: rust-lang#139477 CC ``@cuviper`` r? ``@onur-ozkan``

Rollup of 10 pull requests Successful merges: - rust-lang#139647 (Add unstable parsing of `--extern foo::bar=libbar.rlib` command line options) - rust-lang#139823 (Fix some bootstrap papercuts) - rust-lang#139853 (Disable combining LLD with external llvm-config) - rust-lang#139867 (Fix some tidy paper cuts) - rust-lang#139871 (Fix wrong "move keyword" suggestion for async gen block) - rust-lang#139876 (Make CodeStats' type_sizes public) - rust-lang#139880 (Don't compute name of associated item if it's an RPITIT) - rust-lang#139884 (Update books) - rust-lang#139886 (`borrowck_graphviz_*` attribute tweaks) - rust-lang#139893 (Add test for issue 125668) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2025-04-16T12:11:15Z

I think this failed in rollup: #139895 (comment)

Zalathar · 2025-04-16T12:11:22Z

@bors r-

Kobzol · 2025-04-16T14:09:52Z

Hmm, it failed in post-opt tests. This might be a bit annoying, because this is not external LLVM, but a "local" LLVM, and here we do in fact want to use LLD. I think that we should just print a warning instead of panicking when LLD is configured, and just avoid putting it into the sysroot in that case. @onur-ozkan WDYT?

onur-ozkan · 2025-04-16T14:52:32Z

Hmm, it failed in post-opt tests. This might be a bit annoying, because this is not external LLVM, but a "local" LLVM, and here we do in fact want to use LLD. I think that we should just print a warning instead of panicking when LLD is configured, and just avoid putting it into the sysroot in that case. @onur-ozkan WDYT?

Sounds good to me.

Kobzol · 2025-04-16T15:40:51Z

@bors try

Disable combining LLD with external llvm-config When an external `llvm-config` is used, we don't really know anything about the external LLD, as we don't build it ourselves. Therefore, we probably shouldn't allow using `rust-lld` nor copy it to the target sysroot. Fixes: rust-lang#139477 CC `@cuviper` r? `@onur-ozkan` try-job: dist-x86_64-linux try-job: dist-aarch64-linux

bors · 2025-04-16T15:42:02Z

⌛ Trying commit a870bba with merge b862ceb...

bors · 2025-04-16T17:57:18Z

☀️ Try build successful - checks-actions
Build commit: b862ceb (b862ceb19c9f0acb5dbb6879d7d38231164fd424)

Kobzol · 2025-04-16T17:58:05Z

@rustbot ready

onur-ozkan · 2025-04-16T18:43:57Z

@bors r+

bors · 2025-04-16T18:44:00Z

📌 Commit a870bba has been approved by onur-ozkan

It is now in the queue for this repository.

Disable combining LLD with external llvm-config When an external `llvm-config` is used, we don't really know anything about the external LLD, as we don't build it ourselves. Therefore, we probably shouldn't allow using `rust-lld` nor copy it to the target sysroot. Fixes: rust-lang#139477 CC `@cuviper` r? `@onur-ozkan` try-job: dist-x86_64-linux try-job: dist-aarch64-linux

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#138528 (deref patterns: implement implicit deref patterns) - rust-lang#138934 (support config extensions) - rust-lang#139114 (Implement `pin!()` using `super let`) - rust-lang#139393 (rustdoc-json: Output target feature information) - rust-lang#139553 (sync::mpsc: prevent double free on `Drop`) - rust-lang#139615 (Remove `name_or_empty`) - rust-lang#139853 (Disable combining LLD with external llvm-config) - rust-lang#139913 (rustdoc/clean: Fix lowering of fn params (fixes correctness & HIR vs. middle parity regressions)) - rust-lang#139942 (Ignore aix for tests/ui/erros/pic-linker.rs) r? `@ghost` `@rustbot` modify labels: rollup

Disable combining LLD with external llvm-config When an external `llvm-config` is used, we don't really know anything about the external LLD, as we don't build it ourselves. Therefore, we probably shouldn't allow using `rust-lld` nor copy it to the target sysroot. Fixes: rust-lang#139477 CC `@cuviper` r? `@onur-ozkan` try-job: dist-x86_64-linux try-job: dist-aarch64-linux

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#138528 (deref patterns: implement implicit deref patterns) - rust-lang#138934 (support config extensions) - rust-lang#139393 (rustdoc-json: Output target feature information) - rust-lang#139553 (sync::mpsc: prevent double free on `Drop`) - rust-lang#139615 (Remove `name_or_empty`) - rust-lang#139853 (Disable combining LLD with external llvm-config) - rust-lang#139913 (rustdoc/clean: Fix lowering of fn params (fixes correctness & HIR vs. middle parity regressions)) - rust-lang#139942 (Ignore aix for tests/ui/erros/pic-linker.rs) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138528 (deref patterns: implement implicit deref patterns) - rust-lang#139393 (rustdoc-json: Output target feature information) - rust-lang#139553 (sync::mpsc: prevent double free on `Drop`) - rust-lang#139615 (Remove `name_or_empty`) - rust-lang#139853 (Disable combining LLD with external llvm-config) - rust-lang#139913 (rustdoc/clean: Fix lowering of fn params (fixes correctness & HIR vs. middle parity regressions)) - rust-lang#139942 (Ignore aix for tests/ui/erros/pic-linker.rs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#139853 - Kobzol:lld-llvm-config, r=onur-ozkan Disable combining LLD with external llvm-config When an external `llvm-config` is used, we don't really know anything about the external LLD, as we don't build it ourselves. Therefore, we probably shouldn't allow using `rust-lld` nor copy it to the target sysroot. Fixes: rust-lang#139477 CC ``@cuviper`` r? ``@onur-ozkan`` try-job: dist-x86_64-linux try-job: dist-aarch64-linux

rustbot assigned onur-ozkan Apr 15, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 15, 2025

Kobzol mentioned this pull request Apr 15, 2025

FTBFS tarball rust 1.86.0: generated a symlink in a tarball: rust-lld #139477

Closed

This comment has been minimized.

Sign in to view

Kobzol force-pushed the lld-llvm-config branch from 333ee68 to baab050 Compare April 15, 2025 08:55

onur-ozkan approved these changes Apr 15, 2025

View reviewed changes

Kobzol force-pushed the lld-llvm-config branch from baab050 to d224443 Compare April 15, 2025 10:16

rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Apr 15, 2025

This comment has been minimized.

Sign in to view

Kobzol added 2 commits April 15, 2025 14:12

Move is_builder_target, is_system_llvm and is_rust_llvm from `B…

2907ab5

…uilder` to `Config`

Rename is_builder_target to is_host_target

3c01dfe

Kobzol force-pushed the lld-llvm-config branch from d224443 to 689b4c9 Compare April 15, 2025 12:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2025

Zalathar mentioned this pull request Apr 16, 2025

Rollup of 8 pull requests #139888

Closed

Zalathar mentioned this pull request Apr 16, 2025

Rollup of 10 pull requests #139895

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 16, 2025

Add a warning when combining LLD with external LLVM config

a870bba

Kobzol force-pushed the lld-llvm-config branch from 689b4c9 to a870bba Compare April 16, 2025 15:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2025

matthiaskrgr mentioned this pull request Apr 17, 2025

Rollup of 9 pull requests #139957

Closed

matthiaskrgr mentioned this pull request Apr 17, 2025

Rollup of 8 pull requests #139980

Closed

matthiaskrgr mentioned this pull request Apr 18, 2025

Rollup of 7 pull requests #139996

Merged

bors merged commit ac00a37 into rust-lang:master Apr 18, 2025
7 checks passed

rustbot added this to the 1.88.0 milestone Apr 18, 2025

Kobzol deleted the lld-llvm-config branch April 18, 2025 17:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable combining LLD with external llvm-config #139853

Disable combining LLD with external llvm-config #139853

Kobzol commented Apr 15, 2025 •

edited

Loading

rustbot commented Apr 15, 2025

This comment has been minimized.

onur-ozkan left a comment

onur-ozkan Apr 15, 2025

Kobzol Apr 15, 2025

rustbot commented Apr 15, 2025

Kobzol commented Apr 15, 2025

This comment has been minimized.

onur-ozkan commented Apr 15, 2025

bors commented Apr 15, 2025

Zalathar commented Apr 16, 2025

Zalathar commented Apr 16, 2025

Kobzol commented Apr 16, 2025

onur-ozkan commented Apr 16, 2025

Kobzol commented Apr 16, 2025

bors commented Apr 16, 2025

bors commented Apr 16, 2025

Kobzol commented Apr 16, 2025

onur-ozkan commented Apr 16, 2025

bors commented Apr 16, 2025

Disable combining LLD with external llvm-config #139853

Disable combining LLD with external llvm-config #139853

Conversation

Kobzol commented Apr 15, 2025 • edited Loading

rustbot commented Apr 15, 2025

This comment has been minimized.

onur-ozkan left a comment

Choose a reason for hiding this comment

onur-ozkan Apr 15, 2025

Choose a reason for hiding this comment

Kobzol Apr 15, 2025

Choose a reason for hiding this comment

rustbot commented Apr 15, 2025

Kobzol commented Apr 15, 2025

This comment has been minimized.

onur-ozkan commented Apr 15, 2025

bors commented Apr 15, 2025

Zalathar commented Apr 16, 2025

Zalathar commented Apr 16, 2025

Kobzol commented Apr 16, 2025

onur-ozkan commented Apr 16, 2025

Kobzol commented Apr 16, 2025

bors commented Apr 16, 2025

bors commented Apr 16, 2025

Kobzol commented Apr 16, 2025

onur-ozkan commented Apr 16, 2025

bors commented Apr 16, 2025

Kobzol commented Apr 15, 2025 •

edited

Loading