Skip to content

add retries to remove and create dir all #139870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

add retries to remove and create dir all #139870

merged 3 commits into from
Apr 17, 2025

Conversation

Shourya742
Copy link
Contributor

closes: #139230

r? @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

jieyouxu
jieyouxu requested changes Apr 15, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 15, 2025
@Shourya742 Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from 09b2162 to 74ab918 Compare April 16, 2025 05:11
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

This PR modifies run-make tests.

cc @jieyouxu

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in src/tools/opt-dist

cc @Kobzol

The Miri subtree was changed

cc @rust-lang/miri

@Shourya742 Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from 74ab918 to bd59c94 Compare April 16, 2025 05:20
@Shourya742
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2025
@Shourya742 Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from bd59c94 to 37da1f0 Compare April 16, 2025 06:59
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2025

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @vakaras

@Shourya742 Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from 37da1f0 to b5952db Compare April 16, 2025 06:59
@RalfJung

This comment was marked as off-topic.

Sign in to view
@Shourya742

This comment was marked as off-topic.

Sign in to view
@RalfJung

This comment was marked as off-topic.

Sign in to view
jieyouxu
jieyouxu reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few more nits

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2025
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jieyouxu jieyouxu removed WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) A-run-make Area: port run-make Makefiles to rmake.rs labels Apr 16, 2025
@Shourya742 Shourya742 force-pushed the 2025-04-15-add-retries-to-remove_and_create_dir_all branch from b5952db to d4eab8a Compare April 16, 2025 16:24
@Shourya742
Copy link
Contributor Author

Shourya742 commented Apr 16, 2025 •
edited
Loading

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2025
jieyouxu
jieyouxu approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 17, 2025

📌 Commit d4eab8a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 17, 2025
@matthiaskrgr
Rollup merge of rust-lang#139870 - Shourya742:2025-04-15-add-retries-…
8f303db 
…to-remove_and_create_dir_all, r=jieyouxu

add retries to remove and create dir all

closes: rust-lang#139230

r? `@jieyouxu`
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 17, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 17, 2025
@matthiaskrgr
Rollup merge of rust-lang#139870 - Shourya742:2025-04-15-add-retries-…
db4e287 
…to-remove_and_create_dir_all, r=jieyouxu

add retries to remove and create dir all

closes: rust-lang#139230

r? ``@jieyouxu``
This was referenced Apr 17, 2025
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2025
@bors
Auto merge of rust-lang#139979 - matthiaskrgr:rollup-7wu5169, r=matth…
a15cce2 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#139774 (Fix replacing supertrait aliases in `ReplaceProjectionWith`)
 - rust-lang#139850 (Hide unstable print kinds within emit_unknown_print_request_help in stable channel)
 - rust-lang#139870 (add retries to remove and create dir all)
 - rust-lang#139902 (do not emit `OpaqueCast` projections with `-Znext-solver`)
 - rust-lang#139931 (bootstrap: enable zlib for LLVM for Windows GNU)
 - rust-lang#139935 (Upgrade to `rustc-rayon-core` 0.5.1)
 - rust-lang#139943 (rustdoc: Support inlined cross-crate re-exported trait aliases)
 - rust-lang#139961 (Two `rustc_const_eval` cleanups)
 - rust-lang#139962 (opt-dist: add a flag for running tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cecc7a4 into rust-lang:master Apr 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 17, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2025
@rust-timer
Unrolled build for rust-lang#139870
b3e49fd 
Rollup merge of rust-lang#139870 - Shourya742:2025-04-15-add-retries-to-remove_and_create_dir_all, r=jieyouxu

add retries to remove and create dir all

closes: rust-lang#139230

r? ```@jieyouxu```
This was referenced Apr 21, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbstj fbstj fbstj left review comments

@RalfJung RalfJung RalfJung left review comments

@bjorn3 bjorn3 bjorn3 left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.88.0
Development

Successfully merging this pull request may close these issues.

compiletest remove_and_create_dir_all may need retries
7 participants
@Shourya742 @rustbot @RalfJung @jieyouxu @bors @fbstj @bjorn3