Don't walk into Certainty::Yes goals

[compiler-errors]

Don't walk into Certainty::Yes goals in the pending obligation finding code, since they will not have been stalled on an infer var anyways

[compiler-errors]

@bors2 try @rust-timer queue

[rust-bors]

⌛ Trying commit 54b62fc with merge 3e60047…

To cancel the try build, run the command @bors2 try cancel.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 3e60047 (3e60047b763a2a4010050b95bbae403458280cff)

[rust-timer]

Finished benchmarking commit (3e60047): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.5%	[-16.2%, -0.8%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.1%, secondary -0.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.3%	[4.3%, 4.3%]	1
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-2.1%	[-2.7%, -0.9%]	3
All ❌✅ (primary)	1.1%	[-2.1%, 4.3%]	2

Cycles

Results (secondary -12.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-12.8%	[-14.8%, -9.2%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 750.544s -> 750.657s (0.02%)
Artifact size: 371.78 MiB -> 371.72 MiB (-0.02%)

[compiler-errors]

r? lcnr

[rustbot]

changes to inspect_obligations.rs

cc @compiler-errors, @lcnr

[compiler-errors]

We currently report nested goals as Certainty::Yes even if they had nested goals... we could/should fix that?

[lcnr]

normalizes-to goals?

in InspectGoal::new, we should also eagerly try to prove the nested goals if the normalizes_to_term_hack is Some 🤔

r=me with a FIXME here saying that normalizes-to nested goals are kinda scuffed or actually fix the impl in this PR

[compiler-errors]

normalizes-to goals?

Yes, typo.

[compiler-errors]

Fixed by #142127.

[compiler-errors]

@bors r=lcnr rollup=never

[bors]

📌 Commit db1ceca has been approved by lcnr

It is now in the queue for this repository.