Skip to content

Unify and deduplicate From<T> float tests #150611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
augustocesarperin wants to merge 1 commit into
base: main
Choose a base branch
from
+75 −88
Open

Unify and deduplicate From<T> float tests #150611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions library/coretests/tests/floats/f128.rs
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions library/coretests/tests/floats/f16.rs
View file
Open in desktop

This file was deleted.

78 changes: 75 additions & 3 deletions library/coretests/tests/floats/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,6 @@ macro_rules! float_test {
};
}

mod f128;
mod f16;

float_test! {
name: num,
attrs: {
Expand Down Expand Up @@ -1582,3 +1579,78 @@ float_test! {
assert_biteq!((flt(-3.2)).mul_add(2.4, neg_inf), neg_inf);
}
}

float_test! {
name: from,
attrs: {
f16: #[cfg(any(miri, target_has_reliable_f16))],
f128: #[cfg(any(miri, target_has_reliable_f128))],
},
test<Float> {
assert_biteq!(Float::from(false), Float::ZERO);
assert_biteq!(Float::from(true), Float::ONE);

assert_biteq!(Float::from(u8::MIN), Float::ZERO);
assert_biteq!(Float::from(42_u8), 42.0);
assert_biteq!(Float::from(u8::MAX), 255.0);

assert_biteq!(Float::from(i8::MIN), -128.0);
assert_biteq!(Float::from(42_i8), 42.0);
assert_biteq!(Float::from(i8::MAX), 127.0);
}
}

float_test! {
name: from_u16_i16,
attrs: {
f16: #[cfg(false)],
const f16: #[cfg(false)],
f128: #[cfg(any(miri, target_has_reliable_f128))],
},
test<Float> {
assert_biteq!(Float::from(u16::MIN), Float::ZERO);
assert_biteq!(Float::from(42_u16), 42.0);
assert_biteq!(Float::from(u16::MAX), 65535.0);
assert_biteq!(Float::from(i16::MIN), -32768.0);
assert_biteq!(Float::from(42_i16), 42.0);
assert_biteq!(Float::from(i16::MAX), 32767.0);
}
}

float_test! {
name: from_u32_i32,
attrs: {
f16: #[cfg(false)],
const f16: #[cfg(false)],
f32: #[cfg(false)],
const f32: #[cfg(false)],
f128: #[cfg(any(miri, target_has_reliable_f128))],
},
test<Float> {
assert_biteq!(Float::from(u32::MIN), Float::ZERO);
assert_biteq!(Float::from(42_u32), 42.0);
assert_biteq!(Float::from(u32::MAX), 4294967295.0);
assert_biteq!(Float::from(i32::MIN), -2147483648.0);
assert_biteq!(Float::from(42_i32), 42.0);
assert_biteq!(Float::from(i32::MAX), 2147483647.0);
}
}

// FIXME(f16_f128): Uncomment and adapt these tests once the From<{u64,i64}> impls are added.
// float_test! {
// name: from_u64_i64,
// attrs: {
// f16: #[cfg(false)],
// f32: #[cfg(false)],
// f64: #[cfg(false)],
// f128: #[cfg(any(miri, target_has_reliable_f128))],
// },
// test<Float> {
// assert_biteq!(Float::from(u64::MIN), Float::ZERO);
// assert_biteq!(Float::from(42_u64), 42.0);
// assert_biteq!(Float::from(u64::MAX), 18446744073709551615.0);
// assert_biteq!(Float::from(i64::MIN), -9223372036854775808.0);
// assert_biteq!(Float::from(42_i64), 42.0);
// assert_biteq!(Float::from(i64::MAX), 9223372036854775807.0);
// }
// }
Loading