Skip to content

Improve std::path::Path::join documentation #150677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KaiTomotake wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve std::path::Path::join documentation #150677

KaiTomotake wants to merge 1 commit into from
+9 −0

Conversation

@KaiTomotake
Copy link

@KaiTomotake KaiTomotake commented Jan 4, 2026 •
edited by rustbot
Loading

Adapt PathBuf::push documentation for Path::join and add it to join's docs

#146447

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 10, 2026

r=me with commits squashed

@KaiTomotake
Copy link
Author

KaiTomotake commented Jan 11, 2026

Thanks! Just to confirm:
does “r=me with commits squashed” mean the change is approved as long as I squash the commits?

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

Sign in to view
@rustbot rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2026
@rustbot rustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jan 12, 2026
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 12, 2026 •
edited
Loading

Yes, once this is squashed to one commit I'll approve.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2026
@KaiTomotake
Improve std::path::Path::join documentation
d697b4d 
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs

Fix to comply with tidy

Remove unnecessary whitespace
@KaiTomotake
Copy link
Author

KaiTomotake commented Jan 13, 2026

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 13, 2026
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jan 13, 2026

@bors r+ rollup

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 13, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 13, 2026

📌 Commit d697b4d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150677 - improve-doc, r=Mark-Simulacrum
b8be619 
Improve std::path::Path::join documentation

Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs

rust-lang#146447
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 13, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
@JonathanBrouwer
Rollup merge of rust-lang#150677 - improve-doc, r=Mark-Simulacrum
de20a80 
Improve std::path::Path::join documentation

Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs

rust-lang#146447
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 13, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of #151070 - JonathanBrouwer:rollup-hfZvtaP, r=JonathanBro…
2719969 
…uwer

Rollup of 13 pull requests

Successful merges:

 - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items)
 - #150677 (Improve std::path::Path::join documentation)
 - #150723 (std: move `errno` and related functions into `sys::io`)
 - #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
 - #150771 (Remove legacy homu `try` and `auto` branch mentions)
 - #150915 (Regression test for type params on eii)
 - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg)
 - #151017 (Port the rustc dump attributes to the attribute parser)
 - #151019 (Make `Type::of` support unsized types)
 - #151034 (std: Change UEFI env vars to volatile storage)
 - #151052 (ui: add regression test for macro resolution ICE (issue #150711))
 - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
 - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)

r? @ghost
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 13, 2026
@GuillaumeGomez
Rollup merge of rust-lang#150677 - improve-doc, r=Mark-Simulacrum
dd8cb22 
Improve std::path::Path::join documentation

Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs

rust-lang#146447
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 13, 2026
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 13, 2026
@GuillaumeGomez
Rollup merge of rust-lang#150677 - improve-doc, r=Mark-Simulacrum
7fc878c 
Improve std::path::Path::join documentation

Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs

rust-lang#146447
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 13, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
@bors
Auto merge of #151087 - GuillaumeGomez:rollup-vIdiReJ, r=GuillaumeGomez
4931e09 
Rollup of 13 pull requests

Successful merges:

 - #150587 (triagebot: add A-rustdoc-js autolabel)
 - #150677 (Improve std::path::Path::join documentation)
 - #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
 - #150771 (Remove legacy homu `try` and `auto` branch mentions)
 - #150840 (Make `--print=check-cfg` output compatible `--check-cfg` arguments)
 - #150915 (Regression test for type params on eii)
 - #151017 (Port the rustc dump attributes to the attribute parser)
 - #151019 (Make `Type::of` support unsized types)
 - #151031 (Support arrays in type reflection)
 - #151043 (armv7-unknown-linux-uclibceabihf.md: Fix bootstrap.toml syntax)
 - #151052 (ui: add regression test for macro resolution ICE (issue #150711))
 - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
 - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KaiTomotake @rustbot @rust-log-analyzer @Mark-Simulacrum