-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Couple of improvements to rustc_fluent_macros #150870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Some changes occurred to the CTFE machinery Some changes occurred in exhaustiveness checking cc @Nadrieril Some changes occurred in compiler/rustc_codegen_gcc Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_attr_parsing |
| finish(constants, quote! { include_str!(#relative_ftl_path) }) | ||
| finish( | ||
| constants, | ||
| quote! { include_str!(concat!(env!("CARGO_MANIFEST_DIR"), "/", #relative_ftl_path)) }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine with respect to reproducibility, right?
This comment has been minimized.
This comment has been minimized.
feeb3da to
2975c7e
Compare
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
Rust-analyzer doesn't implement this yet, causing it to show an error for pretty much every lib.rs file you have open due to the fluent macro panicking.
This avoids cascading errors as much as possible.
2975c7e to
90c42f0
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
rust-lang/compiler-team#959 would obsolete this PR if it gets accepted. |
Workaround a feature used by
fluent_messages!that isn't supported by rust-analyzer. And significantly reduce cascading errors when the translation file fails to parse.