Improve precision of Duration-float operations #150933
Open
+257
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
eggyal
commented
Jan 10, 2026
quaternic
reviewed
Jan 10, 2026
quaternic
reviewed
Jan 10, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
eggyal
force-pushed
the
issue-149794
branch
2 times, most recently
from
5844308 to
adc30ec
Compare
This comment has been minimized.
This comment has been minimized.
eggyal
commented
Jan 11, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
eggyal
force-pushed
the
issue-149794
branch
2 times, most recently
from
cf585ba to
c7098b3
Compare
Contributor
Author
|
No, some corner cases are not quite right here. I'll add some more tests and push a fix. @rustbot author |
rustbot
added
S-waiting-on-author
Contributor
Author
|
@rustbot ready |
rustbot
removed
the
S-waiting-on-author
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
eggyal
force-pushed
the
issue-149794
branch
5 times, most recently
from
a52d3a0 to
6827d88
Compare
Rather than convert Duration to a float in order to multiply or divide by a floating point number, which entails a loss of precision, we instead represent both operands as u128 nanoseconds and perform integer arithmetic thereupon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than convert Duration to a float in order to multiply or divide by a floating point number, which entails a loss of precision, we instead represent both operands as u128 nanoseconds and perform integer arithmetic thereupon.
This improvement in precision affects some of the documented examples.
Given that these methods have been stabilised, is it a breaking change to affect their output? If so, this PR obviously cannot be merged as-is: we might instead need to create new methods for this more precise calculation (and possibly deprecate the existing ones).
Fixes #149794
r? libs-api