Remove FeedConstTy and provide ty when lowering const arg
#150962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
fmease
reviewed
Jan 11, 2026
mu001999
force-pushed
the
rm/feed_const_ty
branch
from
037210a to
d0247c8
Compare
This comment has been minimized.
This comment has been minimized.
BoxyUwU
reviewed
Jan 12, 2026
Member
There was a problem hiding this comment.
This is great :)
Can you update type_of.rs to no longer have fn const_arg_anon_type_of and replace its one call site with the logic of the wildcard arm that currently is in const_arg_anon_type_of. In theory none of the other codepaths should be necessary now that we always pass in a type during HIR ty lowering.
mu001999
force-pushed
the
rm/feed_const_ty
branch
from
25c3068 to
7055784
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Seems because the removal of |
mu001999
force-pushed
the
rm/feed_const_ty
branch
from
7055784 to
dbf5ee8
Compare
Contributor
Author
|
Recover |
Member
|
Oh that's unfortunate, I wonder what's going on there |
Contributor
|
☔ The latest upstream changes (presumably #151003) made this pull request unmergeable. Please resolve the merge conflicts. |
mu001999
force-pushed
the
rm/feed_const_ty
branch
from
dbf5ee8 to
d95613a
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@BoxyUwU I think the two failed tests (tests/ui/closures/issue-90871.rs and tests/ui/type/pattern_types/nested.rs) show that we still will call |
This was referenced Jan 13, 2026
Member
|
@bors r+ cool! |
rust-bors
bot
added
S-waiting-on-bors
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 13, 2026
Remove `FeedConstTy` and provide ty when lowering const arg r? @BoxyUwU edit: BoxyUwU `FeedConstTy` currently only provides the expected type of a const argument *sometimes* (e.g. previously array lengths did not do this). This causes problems with mGCA's directly represented const arguments which always need to know their expected type.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jan 13, 2026
Remove `FeedConstTy` and provide ty when lowering const arg r? @BoxyUwU edit: BoxyUwU `FeedConstTy` currently only provides the expected type of a const argument *sometimes* (e.g. previously array lengths did not do this). This causes problems with mGCA's directly represented const arguments which always need to know their expected type.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
…uwer Rollup of 13 pull requests Successful merges: - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items) - #150677 (Improve std::path::Path::join documentation) - #150723 (std: move `errno` and related functions into `sys::io`) - #150737 (diagnostics: make implicit Sized bounds explicit in E0277) - #150771 (Remove legacy homu `try` and `auto` branch mentions) - #150915 (Regression test for type params on eii) - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - #151017 (Port the rustc dump attributes to the attribute parser) - #151019 (Make `Type::of` support unsized types) - #151034 (std: Change UEFI env vars to volatile storage) - #151052 (ui: add regression test for macro resolution ICE (issue #150711)) - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`) - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @BoxyUwU
edit: BoxyUwU
FeedConstTycurrently only provides the expected type of a const argument sometimes (e.g. previously array lengths did not do this). This causes problems with mGCA's directly represented const arguments which always need to know their expected type.