Better handle when trying to iterate on a Range of a type that isn't Step
#151036
+137
−119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
S-waiting-on-review
estebank
force-pushed
the
issue-151026
branch
from
b377155 to
89713fc
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mati865
approved these changes
Jan 13, 2026
estebank
commented
Jan 13, 2026
Comment on lines
1
to
9
| error[E0277]: `std::ops::Range<T>` is not an iterator | ||
| --> missing-bound.rs:2:14 | ||
| | | ||
| 2 | for _ in t {} | ||
| | ^ the trait `Step` is not implemented for `T` | ||
| | ^ not an iterator | ||
| | | ||
| = note: `Range` only implements `Iterator` for select types in the standard library, particularly integers; to see the full list of types, see the documentation for the unstable `Step` trait | ||
| = note: required for `std::ops::Range<T>` to implement `Iterator` | ||
| = note: required for `std::ops::Range<T>` to implement `IntoIterator` |
Contributor
Author
There was a problem hiding this comment.
This tells me that we're missing a path for displaying the original label as a note, like we do in many other cases. Pre-existing.
estebank
commented
Jan 13, 2026
| | ^^^^^^^^^^^ the trait `Step` is not implemented for `bool` | ||
| | ^^^^^^^^^^^ not an iterator | ||
| | | ||
| = help: the nightly-only, unstable trait `Step` is not implemented for `bool` |
Contributor
Author
There was a problem hiding this comment.
This is the note that I would have expected to see in the other case.
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
issue-151026
branch
from
5bd45b1 to
1fe705c
Compare
Contributor
Author
|
@bors r=mati865 |
rust-bors
bot
added
the
S-waiting-on-bors
Contributor
rust-bors
bot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention when a trait bound corresponds to an unstable trait.
Mention
RangewhenStepbound is unment, and explain that only some std types implIteratorforRange.CC #151026