Get rid of QueryVTable::call_query_method_fn

[Zalathar]

Calling the query method to promote a value is equivalent to doing a cache lookup and then calling execute_query_fn, so we can just do that manually instead.

There are two “functional” differences here: If a cache hit occurs, we don't record the hit for self-profiling, and we don't register a read of the dep node. In the context of promotion, which touches all eligible cache entries just before writing the memory-cached values to disk, those two steps should be unnecessary overhead anyway.

r? nnethercote (or compiler)

[Zalathar]

@bors try @rust-timer queue

[nnethercote]

Seems fine, good to get rid of this fn. r=me once perf results come back ok.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 5bc0460 (5bc04606b33438d872679e82b473662e1bdaefcf, parent: d933cf483edf1605142ac6899ff32536c0ad8b22)

[rust-timer]

Finished benchmarking commit (5bc0460): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.1%]	9
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	6
All ❌✅ (primary)	-0.3%	[-0.3%, -0.1%]	9

Max RSS (memory usage)

Results (secondary -5.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.2%	[-5.2%, -5.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.4%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.4%	[2.3%, 2.4%]	2
Regressions ❌ (secondary)	5.3%	[3.0%, 7.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-17.2%	[-17.2%, -17.2%]	1
All ❌✅ (primary)	2.4%	[2.3%, 2.4%]	2

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	23
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	54
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	23

Bootstrap: 481.183s -> 478.983s (-0.46%)
Artifact size: 394.90 MiB -> 394.84 MiB (-0.02%)

[Zalathar]

@bors r=nnethercote

[rust-bors]

📌 Commit bab6f12 has been approved by nnethercote

It is now in the queue for this repository.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Zalathar]

Rebased.

@bors r=nnethercote

[rust-bors]

📌 Commit 9012d4e has been approved by nnethercote

It is now in the queue for this repository.