Avoid duplicated query modifier comments.#153428
Open
nnethercote wants to merge 3 commits intorust-lang:mainfrom
Open
Avoid duplicated query modifier comments.#153428nnethercote wants to merge 3 commits intorust-lang:mainfrom
nnethercote wants to merge 3 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-query-system
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
S-waiting-on-author
Contributor
Author
|
r? @Zalathar |
Collaborator
|
|
nnethercote
force-pushed
the
fix-query-comments
branch
from
1876e12 to
cf24b23
Compare
nnethercote
changed the title
rustbot
added
S-waiting-on-review
Zalathar
reviewed
Mar 5, 2026
nnethercote
force-pushed
the
fix-query-comments
branch
from
cf24b23 to
e79b2a1
Compare
This comment has been minimized.
This comment has been minimized.
Because "delayed bug" is the correct term used everywhere else, e.g. `Level::DelayedBug`, `DiagCtxtHandle::delayed_bug`.
By removing the ones in `compiler/rustc_middle/src/queries.rs`, and making `compiler/rustc_middle/src/query/modifiers.rs` the single source of truth.
To `cache_on_disk_if` to match the query modifier name.
nnethercote
force-pushed
the
fix-query-comments
branch
from
e79b2a1 to
78c7d51
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
I rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently some duplication.