Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse the syntax described in RFC 2632 #67820

Merged
merged 13 commits into from
Jan 10, 2020
Merged

Parse the syntax described in RFC 2632 #67820

merged 13 commits into from
Jan 10, 2020

Commits on Jan 10, 2020

  1. Add const_trait_impl feature gate

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    63e2e44 View commit details
    Browse the repository at this point in the history

  2. Add const_trait_bound_opt_out feature gate

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    6fc4158 View commit details
    Browse the repository at this point in the history

  3. Add a constness field to ast::TraitRef 

    This is used for both the `?const` syntax in bounds as well as the `impl
const Trait` syntax. I also considered handling these separately by
adding a variant of `TraitBoundModifier` and a field to
`ItemKind::Impl`, but this approach was less intrusive.
    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    fd4a6a1 View commit details
    Browse the repository at this point in the history

  4. Parse impl const Trait for Ty syntax

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    1c3fe9d View commit details
    Browse the repository at this point in the history

  5. Parse ?const Trait bound syntax 

    The grammar also handles `?const ?Trait` even though this is
semantically redundant.
    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    0cf52a7 View commit details
    Browse the repository at this point in the history

  6. Error when new syntax is lowered 

    This means the new syntax will always fail to compile, even when the
feature gate is enabled. These checks will be removed in a later PR
once the implementation is done.
    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    b390fc4 View commit details
    Browse the repository at this point in the history

  7. Reject const in inherent impls

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    31edbe9 View commit details
    Browse the repository at this point in the history

  8. Check for ?const in invalid contexts during AST validation

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    d843e00 View commit details
    Browse the repository at this point in the history

  9. Add tests for RFC 2632

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    343e157 View commit details
    Browse the repository at this point in the history

  10. Call all visit methods on trait definitions

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    b6b11f0 View commit details
    Browse the repository at this point in the history

  11. Add test for ?const and ? on the same bound

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    9950a1f View commit details
    Browse the repository at this point in the history

  12. Make bound_context more like neighboring functions

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    14730ed View commit details
    Browse the repository at this point in the history

  13. Add test for ?const in nested impl/dyn trait

    @ecstatic-morse
    ecstatic-morse committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    fd1c003 View commit details
    Browse the repository at this point in the history