Add some more regression tests #77956
Conversation
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-testsuite
| use std::rc::Rc; | ||
| use std::sync::Arc; | ||
|
|
||
| pub trait CastTo<T: ?Sized>: Unsize<T> { |
There was a problem hiding this comment.
Any reason this is not using the minimal version that's in the issue description (as opposed to what's in the playground?)
There was a problem hiding this comment.
Ah, good point! I assumed that both examples were the same.
|
Overall LGTM, r=me but not instructing bors just in case you want to address the comment above, either way choice's yours. As a side comment, these would have been easier to review if they were split into PRs for each of the |
|
Addressed the review via d80f93d and rebased to make sure the diagnostics aren't changed.
Fair enough, but in this case, #73905 fixed 10+ ICEs so it would have needed some more hustle :) |
|
📌 Commit d80f93d has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
This is another round of #77741. Tested with
debug-assertions=trueand it passed on my local.Closes #70877
Closes #70944
Closes #71659
Closes #74816
Closes #75707
Closes #75983
(Skipped #63355 because I'm not sure about the error.)