-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use brotli to compress self profile response #1968
Conversation
It will take about 22s to load both directory giving gzip into the perfetto, and using brotli & content-encoding: brotli by my eyes & stopwatch. |
(Current production RLO takes about 200s to load. so this makes x10 faster. ) |
Because we don't have #1896 yet, it is not easy to fully test (and benchmark) this locally. So I guess we can try it on the live server and see how fast it is in practice. |
Looks good! :) Was |
I just took benchmark and changed to 4.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the benchmark! The comment in server.rs
said that 4
might be too slow, maybe on the production server it will be a bit worse, but I'm fine with starting with 4
, it looks like it has a good trade-off locally! It is surprising that 5
produces a larger output than 4
though.
Thanks for working on this ❤️
alternative to #1966
This PR is using brotli to compress and consider Accept-Encoding header according to previous PR's discussion.