Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional backends parameter to benchmarking requests #1992

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

lqd
Copy link
Member

@lqd lqd commented Oct 11, 2024

Opening as draft as I don't know how to test this: how do I simulate locally a request to benchmark a try build @Kobzol? Do I have to manually add rows to the database like in the 18th century?! :p.

This should 🤞 allow choosing which codegen backends we want to use for benchmarks, from the GH benchmarking requests. Hopefully. Maybe. I don't know how to test that it works, I don't know where is the documentation describing how to run these realistic workflows locally.

(Note that I chose to specifically not document the parameter in the help page, until we can test it out a bit in the real world, after this PR is completed)

@lqd
Copy link
Member Author

lqd commented Oct 11, 2024

won't work plot twist

@lqd lqd closed this Oct 11, 2024
@lqd lqd deleted the cg_clif branch October 11, 2024 21:27
@lqd lqd restored the cg_clif branch October 14, 2024 16:46
@lqd lqd reopened this Nov 5, 2024
@lqd
Copy link
Member Author

lqd commented Nov 5, 2024

I'm not sure it's necessary, but it seemed safer to not parse for example include= as a Some("") arguments. I'm not sure how that would go in the DB with an empty string, so I also filtered these as being absent from the command.

Probably more ready for review, but I still can't really test this easily. So still draft :3.

@lqd lqd requested a review from Kobzol November 5, 2024 22:10
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Left one nit. Since we don't really have a way to tell the users if they choose an invalid backend, I would make the backend parsing a bit more lenient.

collector/src/bin/collector.rs Outdated Show resolved Hide resolved
@lqd lqd marked this pull request as ready for review November 15, 2024 18:27
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@Kobzol Kobzol merged commit e6488b4 into rust-lang:master Nov 17, 2024
11 checks passed
@lqd lqd deleted the cg_clif branch November 18, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants