-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS uname -m
can lie due to Rosetta shenanigans
#3438
Conversation
uname -m
can lie due to Rosetta shenanigans
Fix originally provided in JuliaLang/juliaup#701
e5c3843
to
4dfe254
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by review: this makes sense to me.
Are the CI runs expected to be flaky?
@djc Thanks for the review!
I don't think so. The causes of 3 unsuccessful runs are completely different. What happened? 🤔️ |
bbecd2d
to
2b9619c
Compare
There was indeed a tiny detail regarding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it's not possible to get an i386 binary running on Apple silicon?
Perhaps querying hw.optional and grepping for the sub keys we understand would be better?
@rbtcollins No. AFAIK Apple's transition to ARM64 happened after having explicitly banned all x86_32 binaries in a previous macOS major upgrade, so an x86_32 binary can never run on ARM64 even with Rosetta 2 enabled. The x86_32 compatibility part is for the old macOS versions before that ban. |
Great. Could you please document that in a comment - I think its sufficiently specialised knowledge that we'll forget in a few weeks :) |
2b9619c
to
067a784
Compare
@rbtcollins Done. |
067a784
to
e2c2cf8
Compare
macOS `uname -m` can lie due to Rosetta shenanigans
Closes #3419.
Originally provided in JuliaLang/juliaup#701, this shell script fix uses
sysctl
to prevent Rosetta 2 from lying about the system's actual CPU architecture.Possibly related: #3068