Avoid printing a warning about settings.toml on a fresh install#4746
Open
FranciscoTGouveia wants to merge 1 commit intorust-lang:mainfrom
Open
Avoid printing a warning about settings.toml on a fresh install#4746FranciscoTGouveia wants to merge 1 commit intorust-lang:mainfrom
settings.toml on a fresh install#4746FranciscoTGouveia wants to merge 1 commit intorust-lang:mainfrom
Conversation
djc
reviewed
Mar 13, 2026
FranciscoTGouveia
force-pushed
the
settings-fresh-install
branch
from
d94b85d to
5235697
Compare
rami3l
approved these changes
Mar 13, 2026
FranciscoTGouveia
force-pushed
the
settings-fresh-install
branch
from
5235697 to
cfbb48d
Compare
ChrisDenton
approved these changes
Mar 13, 2026
FranciscoTGouveia
force-pushed
the
settings-fresh-install
branch
from
cfbb48d to
f2c74c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (partially) #4744.
Now, in a fresh install, a warning about an already-existing
setting.tomlfile is not printed.Feedback on the wording of the comment is appreciated.