Assign PR assignment based on work queue #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check is specifically used when assigning from the Github web UI
8 tasks
jackh726
reviewed
Apr 3, 2024
jackh726
reviewed
Apr 3, 2024
jackh726
reviewed
Apr 9, 2024
apiraino
force-pushed
the
assign-prs-based-on-work-queue
branch
from
bd923e9
to
a8b49b1
Compare
|
@jackh726 I've applied your suggestions, thanks! As discussed, let's leave this here for a moment until we first merge a patch allowing people to set their own workload. Going to prepare it in short. |
|
#1790 is up for review |
|
I think you may have misunderstood. I would like to merge this before we enable allowing people to change their setting. |
jackh726
reviewed
Apr 15, 2024
Add checks in multiple points when identifying or finding an assignee. Filter out team members currently not having capacity, return messages instructing what to do in case the assignment is rejected.
apiraino
force-pushed
the
assign-prs-based-on-work-queue
branch
from
a8b49b1
to
8030301
Compare
Yes, I got it the other way around, sorry. Anyway, this patch looks green. If you don't have other suggestions we can move on 👍 |
jackh726
approved these changes
Apr 16, 2024
apiraino
added a commit
to apiraino/triagebot
that referenced
this pull request
Apr 16, 2024
This is a version of rust-lang#1786 that fixes the two following bugs: There were 2 bugs: 1. the initial migration wasn't formatted correctly and the new schema changes weren't applied 2. The SELECT to find a reviewer would return wrong results when a team member had NULL in the table `review_prefs.max_assigned_prs`
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the new way of assigning pull requests reviews (designed in #1753). When this PR is merged, PRs in
rust-lang/rustwill be assigned based on user preferences. These can be queried from Zulip (see docs).If no preferences are set, PRs will be just assigned (like always).
There are multiple points where PRs are assigned (via comment or using the GH UI), I've tried to cover all cases, took some time to test them all. The amount of changes reflect that it is not so easy to catch all spots where this happens. I wish I could make a smaller patch but I think this is an all-or-nothing situation where all cases should be handled at once.
Also modified the zulip triagebot command
work showto return the # work queue capacity set by the user. This is helpful in case a PR assignment is rejected. A PR to update the documentation will follow-up after merge of this.If a PR assignment is rejected we will return a message with some context. Examples:
Failed PR assignment to a user:
Failed self-assignment:
r? @jackh726