Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more parameters to the project goals message #1836

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

nikomatsakis
Copy link
Contributor

Also, write the code to automatically ping on a regular cadence, but don't yet schedule it.

I'm not sure how I would schedule it! Probably a good idea to land this first without an automatic schedule and run it manually for a bit. But I'd like to know where in the code I have to go.

r? @jackh726

Also, write the code to automatically ping
on a regular cadence, but don't yet schedule it.
@apiraino
Copy link
Contributor

To have an idea on where to touch to add a scheduled cronjob, you can have a look at a recent patch where I removed a scheduled job (and do the opposite 🙂 ). The interesting code is all in ./src/jobs.rs, in your handler you have to impl Job and add a name() and a run().

I don't remember offhand if I ever understood the machinery to manually trigger a job. Maybe creating a small binary in ./src/bin to run the Job?

@@ -46,6 +46,7 @@ ignore = "0.4.18"
postgres-types = { version = "0.2.4", features = ["derive"] }
cron = { version = "0.12.0" }
bytes = "1.1.0"
structopt = "0.3.26"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's surprising to me or not that we don't already have a CLI parser.

@jackh726 jackh726 merged commit 330e790 into rust-lang:master Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants