feat: add detailed error handling for job deserialization in jobs.rs#1846
Closed
techvoyagerX wants to merge 1 commit intorust-lang:masterfrom
Closed
feat: add detailed error handling for job deserialization in jobs.rs#1846techvoyagerX wants to merge 1 commit intorust-lang:masterfrom
techvoyagerX wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
Thanks for the PR! These don't look like functions that should fail, and we would prefer to not add this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces enhanced error handling in the deserialize_job function within jobs.rs. The update provides field-specific error messages, improving traceability and making it easier to identify the source of deserialization failures. Each field (id, name, scheduled_at, metadata, executed_at, and error_message) now has its own error context, which helps with debugging and improves overall reliability.