Handle pushes and rename for rendered links #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
commented
Oct 30, 2024
| @@ -34,65 +36,83 @@ async fn add_rendered_link(ctx: &Context, e: &IssuesEvent, prefix: &str) -> anyh | |||
| if e.action == IssuesAction::Opened | |||
| || e.action == IssuesAction::Closed | |||
| || e.action == IssuesAction::Reopened | |||
| || e.action == IssuesAction::Synchronize | |||
There was a problem hiding this comment.
I originally though I would have to go through the PushEvent instead of the Issue/PushRequestEvent, but it seems to be as simple as checking the synchronize action, yay for simplicity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1848 to handle new commits/pushes on PR with rendered link.
I also added the logic to remove a rendered link if we can't point to it anymore, as well as a small optimize to avoid unnecessarily updating the body if not necessary.
Fixes #1803 (for real this time)
r? @ehuss