Extend user loading from the DB #1908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As usernames can change over time.
apiraino
reviewed
Feb 20, 2025
Comment on lines
+32
to
+38
| Ok(row.map(|row| { | ||
| let username: &str = row.get(0); | ||
| User { | ||
| id: user_id, | ||
| login: username.to_string(), | ||
| } | ||
| })) |
Contributor
There was a problem hiding this comment.
I think if you SELECT * then you can just Ok(row.into()) but it's a matter of preference ...
Member
Author
There was a problem hiding this comment.
We don't currently implement From<tokio_postgres::Row> for User anywhere :( Which goes back to my comment that we kind of misuse the GitHub user to also mean the database user.
Introducing a separate type would mean doing some conversions, but I guess that if we want to keep the users table, it's the Right Thing™ to do, in the long term. What do you think? :)
apiraino
approved these changes
Feb 20, 2025
Member
Author
|
I merged it for now, we can do the refactoring of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split these changes from a larger PR that I'm working on that adds the option to set max review PR capacity.
It's a bit fishy that we user the GitHub
Usertype, which is returned from webhooks, to also represent the user type in the DB, but so far they are pretty much the same, so unless we need to separate them, I'd keep it that way to keep the code simpler.