You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current colors are very low contrast, and therefore very hard to read. This replaces the colors with significantly brighter ones to improve contrast a lot.
The red drifted a lot into the orange, because when making the red brighter, it just got harder to read for me because red on black is bad combination. So i just made it slightly orange, which looks a lot better. I did not pick the colors from git range-diff itself because the red there is still pretty low contrast.
The colors now have a comfortable ~4.55 (AA accessibility) contrast according to developer tools.
The current colors are very low contrast, and therefore very hard to
read. This replaces the colors with significantly brighter ones to
improve contrast a lot.
The red drifted a lot into the orange, because when making the red
brighter, it just got *harder* to read for me because red on black is
bad combination. So i just made it slightly orange, which looks a lot
better. I did not pick the colors from `git range-diff` itself because
the red there is still pretty low contrast.
The colors now have a comfortable ~4.55 (AA accessibility) contrast
according to developer tools.
I tried playing with some red colors but the contrast checker wasn't very happy. The only thing I can think of would be to go for more brown-ish colors (rgb(185, 98, 72) in the example below), there the distinction is more pronounced.
Yeah I think changing the hue is a good strategy, I also went a bit into the orange originally. I think I'd make that brown a bit brighter, I don't find the contrast very good. But something along those lines should work probably and give the visible contrast between before and after.
We experimented in private and found that pastel colors provided more contrast with the bright red and black background, so let's go with that. rgb(255, 159, 131)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current colors are very low contrast, and therefore very hard to read. This replaces the colors with significantly brighter ones to improve contrast a lot.
The red drifted a lot into the orange, because when making the red brighter, it just got harder to read for me because red on black is bad combination. So i just made it slightly orange, which looks a lot better. I did not pick the colors from
git range-diffitself because the red there is still pretty low contrast.The colors now have a comfortable ~4.55 (AA accessibility) contrast according to developer tools.
fixes #2183