Improve our handling of user facing errors #2210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
force-pushed
the
better-user-error
branch
from
7a6ffb3 to
87d1c44
Compare
Kobzol
approved these changes
Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having each user error (like
UnknownLabels) be it's own error type, group all the user errors under theUserErrortype, which now becomes a enum.This simplifies the handling as it means that we only have to catch one type
UserError, and post a comment for it on the issue. It also avoids the need for each handler to catch all the user errors and do a manual handling (issue_handlers!andcommand_handlers!do that for them).This also avoid accidentally eating the error instead of posting it to the user.
I have tested the changes on my own test repo with success.
Best reviewed commit by commit.