Handle missing author in gh-comments by using the ghost account #2264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Feb 2, 2026
Kobzol
approved these changes
Feb 2, 2026
Member
|
I think it's better to make it more explicit, so I like this version better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change our de-serialization of the author field for the
/gh-commentsendpoint as GitHub GraphQl api can return anullauthor when the account/user no longer exist.In that case we should just do what GitHub does and link it to the ghost account.
Fun fact: I discovered this bug while at FOSDEM, I was looking at some of our most commented issues and rust-lang/rust#32838 was not loading at all due to having deleted accounts.