ndk-build: Make platform SDK parsing more robust and ignore minor suffix #75
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minor suffix of an SDK version is not something that can be targeted or conveyed in an Android app; ignore it for now as we only use this to determine the highest API level to target. However `fn platform_dir()` independently tries to reconstruct this path based on an API target and now has no idea to append `.1` if only `android-36.1` happens to be installed for instance. This should be brought back in sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
The minor suffix of an SDK version is not something that can be targeted or conveyed in an Android app; ignore it for now as we only use this to determine the highest API level to target.
However
fn platform_dir()independently tries to reconstruct this path based on an API target and now has no idea to append.1if onlyandroid-36.1happens to be installed for instance. This should be brought back in sync.