Merged
Conversation
cathay4t
force-pushed
the
clean_up_exports
branch
from
dd947a8 to
e50de93
Compare
little-dude
approved these changes
Jul 3, 2024
Instead of `pub use foo::*`, we should be explicitly define our public types. Signed-off-by: Gris Ge <[email protected]>
cathay4t
force-pushed
the
clean_up_exports
branch
from
e50de93 to
4631b3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
pub use foo::*, we should be explicitly define our publictypes.