-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare new version of acpi
#197
Conversation
Rearranging the imported names was necessary to add the `alloc` feature anyways, and I thought this looked a little neater while I was here.
Most people won't care much about the "new" `allocator_api` work, so add `new` methods that just use the globally-set allocator too.
This is apparently better practice.
`aml` should also be moved to the 2021 edition at some point
A thought that's emerged from doing this is, of course, that we no longer really require the We could move all of the functionality of Edit: actually this wouldn't be backwards-compatible, because types created manually from |
Now `acpi` can be used from an allocator-less environment, the original motivation of the `rsdp` crate has been removed. We can therefore move towards deprecating it, and maintaining one less crate!
@alnyan this PR now moves No hurry at all but just giving you a heads up in case you have a good idea of additions that may need to be made - this could be done before this release to avoid another breaking change in the future. |
🚀 This has been a long time coming, and will hopefully be the last major version needed for |
acpi
, and so must not be merged without a major version bumpThis PR prepares to publish a new version of
acpi
. Mainly, it tidies up the edges around theallocator_api
feature by adding a newalloc
feature that just uses the globally-set allocator; this will be the behaviour the majority of users want.It's also an opportunity to round off any rough edges that only comes around occasionally, which is why it's taken so long for me to get around to. Apologies for the inordinately long time this has seemed to take though, everyone - it's one of those things that has slipped again and again, and now looks like an embarrassingly small diff.
That being said - if there's any changes anyone would like to see made before another version of
acpi
is released, now is the chance - it will likely be a similarly long delay to me publishing the next one ;)alloc
feature + relevantnew
methodsrsdp
back intoacpi
acpi
rsdp
(with readme note marking deprecation)