improve VirtAddr Add & Sub impls
#543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the error message didn't make it immediately obvious what went wrong. Let's be a bit more explicit. Note that "attempt to add/subtract with overflow" is the panic message used by Rust for normal arithmetic operations.
Document when the functions panic and mention Step as an alternative for those looking for a successor/predecessor operation.
Freax13
force-pushed
the
enhancement/address-gap-panics
branch
from
bfb71b2 to
0de6929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the panic messages and documentation for
VirtAddr'sAdd/Subimpls.Cc @tsatke
Closes #541