Skip to content

Conversation

@newpavlov
Copy link
Member

No description provided.

@newpavlov newpavlov merged commit 957e1f1 into master Oct 31, 2025
13 checks passed
@newpavlov newpavlov deleted the ci/tweak_release branch October 31, 2025 16:31
@newpavlov
Copy link
Member Author

@dhardy
Could you configure trusted publishing for rand_core by following instructions here? Otherwise we get the following error:

Error: Failed to retrieve token from Cargo registry. Status: 400. Error: No Trusted Publishing config found for repository rust-random/core.

Comment on lines +25 to +27
RELEASE_VERSION="${{ github.ref_name.slice }}"
echo "Version: $RELEASE_VERSION"
RELEASE_BODY=$(awk -v ver="[${RELEASE_VERSION:1}]" '/^## / { if (p) { exit }; if ($2 == ver) { p=1; next } } p && NF' CHANGELOG.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RELEASE_VERSION will have a v in it, causing awk not to match the result.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, note the :1 part, it removes the first character.

@dhardy
Copy link
Member

dhardy commented Oct 31, 2025

I configured crates.io

@newpavlov
Copy link
Member Author

newpavlov commented Oct 31, 2025

Now you need to approve the workflow (I added the protection rule to the environment).

@dhardy
Copy link
Member

dhardy commented Oct 31, 2025

I approved the release. It wasn't clear if this is a one-off approval for the workflow or not.

The GitHub release failed due to HTTP 403: Resource not accessible by integration. The environment and permissions were changed since this succeeded.

@newpavlov
Copy link
Member Author

newpavlov commented Oct 31, 2025

Hm... Should we change the environment settings somehow? Or is because of permissions?

UPD: Ah, it seems release creation requires write permissions.

@dhardy
Copy link
Member

dhardy commented Nov 1, 2025

The last run appears to have been successful but doesn't correspond to anything: I guess you deleted the resulting GH release?

I think we should probably not make a GH release for pre-releases. (Or if we do want to, we can't use this awk script.)

@newpavlov
Copy link
Member Author

Yes, I deleted the results.

I think we should probably not make a GH release for pre-releases.

Good idea. I will try to tweak the config later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants