-
Notifications
You must be signed in to change notification settings - Fork 13
Separate Key
into Character
and NamedKey
#50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please rebase the PR. I wonder if it is possible to have a |
0b833c9
to
4d2a4db
Compare
My main argument here is that There's also a question about normalization; technically
Would definitely be technically possible, but wouldn't really help Winit which also wants extra variants, such as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I will merge it with the nit addressed.
Done! |
@madsmtm The docs need to used named key.
|
This makes most of the key Copy, and allows other crates like Winit to more easily use their own string types.
This makes most of the key
Copy
, and allows other crates like Winit to more easily use their own string types.See rust-windowing/winit#2995 and rust-windowing/winit#3143 for discussion on a similar change in Winit.
Part of #19.