Add ActiveEventLoop::create_proxy()
#3764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested review from
MarijnS95,
jackpot51,
kchibisov,
madsmtm and
notgull
as code owners
madsmtm
approved these changes
Jun 28, 2024
daxpedda
force-pushed
the
active-event-loop-proxy
branch
from
de3d507 to
6d3872c
Compare
Member
Author
|
No changes, just force-pushed to jump-start the CI, some infrastructure failure from GitHub. |
kchibisov
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ActiveEventLoop::create_proxy(), letting users createEventLoopProxyfrom inside the event loop.Internally I basically just moved
backend::EventLoop::create_proxy()tobackend::ActiveEventLoop::create_proxy().Fixes #3741.