Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add safe area and document coordinate systems #3890

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Add safe area and document coordinate systems #3890

wants to merge 38 commits into from

Commits on Sep 10, 2024

  1. Add safe area and document coordinate systems 

    Added `Window::safe_area`, which describes the area of the surface that
is unobstructed by notches, bezels etc. The drawing code in the examples
have been updated to draw a star inside the safe area, and the plain
background outside of it.

Also renamed `Window::inner_position` to `Window::surface_position`, and
changed it to from screen coordinates to window coordinates, to better
align how these coordinate systems work together.

Finally, added some SVG images and documentation to describe how all of
this works.
    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    98a9914 View commit details
    Browse the repository at this point in the history

  2. Attempt to show better show that positions are relative to something

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    335a1c6 View commit details
    Browse the repository at this point in the history

  3. Remove extra comment that was more confusing than helpful

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    3cd2fa6 View commit details
    Browse the repository at this point in the history

  4. Improve docs, allow safe area to include transparent title bar

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9bcd3ff View commit details
    Browse the repository at this point in the history

  5. Use possibly negative values for surface position 

    Dunno, I can imagine that it will happen on some platforms
    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bec2ed1 View commit details
    Browse the repository at this point in the history

  6. Fix safe_area on macOS < 11

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    81c92eb View commit details
    Browse the repository at this point in the history

  7. Fix outer_size on iOS

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    d5d8e30 View commit details
    Browse the repository at this point in the history

  8. Remove draw.io files from typos check

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    b1fee88 View commit details
    Browse the repository at this point in the history

  9. Fix doc link

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    5df9eb8 View commit details
    Browse the repository at this point in the history

  10. Fix SurfaceResized on iOS

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    da7942e View commit details
    Browse the repository at this point in the history

  11. Always redraw when the safe area changes

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9f080a5 View commit details
    Browse the repository at this point in the history

  12. Properly set up typos check

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bc12e13 View commit details
    Browse the repository at this point in the history

  13. Add Android, Orbital, Web, Windows, Wayland and X11 implementations 

    Very bare-bones, probably not correct
    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    287fd8d View commit details
    Browse the repository at this point in the history

  14. Fix Android inner_position/surface_position name

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ba76cc6 View commit details
    Browse the repository at this point in the history

  15. Fix clippy warning on Windows

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    8561d3b View commit details
    Browse the repository at this point in the history

  16. Fix size of desktop coordinate systems image

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    feb686a View commit details
    Browse the repository at this point in the history

  17. Note on android that there's events for safe area insets

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    e878c59 View commit details
    Browse the repository at this point in the history

  18. Add docs on also emitting RedrawRequested when safe area changes

    @madsmtm
    madsmtm committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c7523d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Move docs on safe area to # Drawing on the window

    @madsmtm
    madsmtm committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    01552d5 View commit details
    Browse the repository at this point in the history

  2. Remove comment about CSD in safe_area on wayland

    @madsmtm
    madsmtm committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    45326fb View commit details
    Browse the repository at this point in the history

  3. Remove fixmes, use issue to track instead

    @madsmtm
    madsmtm committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c651490 View commit details
    Browse the repository at this point in the history

  4. Change note on negative surface position

    @madsmtm
    madsmtm committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c1ea82a View commit details
    Browse the repository at this point in the history

  5. Make safe area position vs. size a bit clearer

    @madsmtm
    madsmtm committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    39f40c7 View commit details
    Browse the repository at this point in the history

  6. Add dot and arrow to the start and end of position indicators

    @madsmtm
    madsmtm committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    131eaa1 View commit details
    Browse the repository at this point in the history

  7. macOS: Guarantee that SurfaceResized is emitted on safe area change 

    To support on Alacritty
    @madsmtm
    madsmtm committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    62a95a5 View commit details
    Browse the repository at this point in the history

  8. Don't mention Alacritty

    @madsmtm
    madsmtm committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3b3928e View commit details
    Browse the repository at this point in the history

  9. Comment before mobile picture

    @madsmtm
    madsmtm authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    992778a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Implement Web

    @daxpedda
    daxpedda committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1ffa29b View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Improve rustfmt note

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    025bb67 View commit details
    Browse the repository at this point in the history

  2. doc function

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2caf761 View commit details
    Browse the repository at this point in the history

  3. Document that safe area != occlusion

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    9a4c51c View commit details
    Browse the repository at this point in the history

  4. Add inset types

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    51269ce View commit details
    Browse the repository at this point in the history

  5. Use insets instead of rectangle

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    12f3666 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch '0origin/master' into madsmtm/safe-area

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    00fe76e View commit details
    Browse the repository at this point in the history

  7. Fix web

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c288aeb View commit details
    Browse the repository at this point in the history

  8. Remove test code

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    566b790 View commit details
    Browse the repository at this point in the history

  9. Update mobile diagram

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    8143515 View commit details
    Browse the repository at this point in the history

  10. Fix broken doc

    @madsmtm
    madsmtm committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    773b002 View commit details
    Browse the repository at this point in the history