macOS: Align scancode conversions with Chromium and Firefox#4019
Merged
macOS: Align scancode conversions with Chromium and Firefox#4019
Conversation
4 tasks
4c17a91 to
0501f63
Compare
0501f63 to
fd5643e
Compare
4 tasks
fd5643e to
7258df1
Compare
4 tasks
6dfc6f6 to
021d490
Compare
This had become out of sync with scancode_to_physicalkey
021d490 to
365524a
Compare
kchibisov
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went spelunking, and found Chromium's and Firefox' conversion tables. So I thought I would check our code against that, and lo and behold, we did indeed have some inconsistencies.
This PR fixes those.
changelogmodule if knowledge of this change could be valuable to users