Skip to content

macOS: Align scancode conversions with Chromium and Firefox #4019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2024
Merged

macOS: Align scancode conversions with Chromium and Firefox #4019

merged 3 commits into from
Dec 3, 2024

Conversation

@madsmtm
Copy link
Member

@madsmtm madsmtm commented Dec 1, 2024

I went spelunking, and found Chromium's and Firefox' conversion tables. So I thought I would check our code against that, and lo and behold, we did indeed have some inconsistencies.

This PR fixes those.

  • Tested on all platforms changed
    • Tested as far as possible, given that I don't own keyboards that have most of these keys.
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@madsmtm madsmtm added B - bug Dang, that shouldn't have happened S - enhancement Wouldn't this be the coolest? DS - appkit Affects the AppKit/macOS backend labels Dec 1, 2024
@madsmtm madsmtm mentioned this pull request Dec 1, 2024
Merged
4 tasks
@madsmtm madsmtm force-pushed the madsmtm/fix-macos-scancode-conversions branch from 4c17a91 to 0501f63 Compare December 1, 2024 20:15
@madsmtm madsmtm changed the title Improve macOS scancode conversions macOS: Align scancode conversions with Chromium and Firefox Dec 1, 2024
@madsmtm madsmtm force-pushed the madsmtm/fix-macos-scancode-conversions branch from 0501f63 to fd5643e Compare December 1, 2024 20:17
@madsmtm madsmtm mentioned this pull request Dec 1, 2024
Merged
4 tasks
@madsmtm madsmtm force-pushed the madsmtm/fix-macos-scancode-conversions branch from fd5643e to 7258df1 Compare December 1, 2024 21:19
@madsmtm madsmtm mentioned this pull request Dec 1, 2024
Open
4 tasks
@madsmtm madsmtm force-pushed the madsmtm/fix-macos-scancode-conversions branch 3 times, most recently from 6dfc6f6 to 021d490 Compare December 1, 2024 23:06
@madsmtm madsmtm force-pushed the madsmtm/fix-macos-scancode-conversions branch from 021d490 to 365524a Compare December 2, 2024 12:11
@madsmtm madsmtm added this to the Version 0.31.0 milestone Dec 3, 2024
@madsmtm madsmtm merged commit edca3eb into master Dec 3, 2024
58 checks passed
@madsmtm madsmtm deleted the madsmtm/fix-macos-scancode-conversions branch December 3, 2024 17:18
@madsmtm madsmtm mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kchibisov kchibisov kchibisov approved these changes

Assignees

No one assigned

Labels

B - bug Dang, that shouldn't have happened DS - appkit Affects the AppKit/macOS backend S - enhancement Wouldn't this be the coolest?

Milestone

Version 0.31.0

Development

Successfully merging this pull request may close these issues.

3 participants

@madsmtm @kchibisov