Implement ability to make non-activating window on macOS#4035
Merged
madsmtm merged 4 commits intorust-windowing:masterfrom Dec 12, 2024
Merged
Implement ability to make non-activating window on macOS#4035madsmtm merged 4 commits intorust-windowing:masterfrom
madsmtm merged 4 commits intorust-windowing:masterfrom
Conversation
Exidex
force-pushed
the
ns-panel
branch
2 times, most recently
from
e301605 to
2dd376c
Compare
madsmtm
added
S - enhancement
Exidex
force-pushed
the
ns-panel
branch
2 times, most recently
from
d6ad01c to
eb93eac
Compare
madsmtm
approved these changes
Dec 12, 2024
Member
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Thanks, just a few nits, I'll fix them myself through GitHub's UI ('cause I'm too lazy to check out your branch locally ;) )
madsmtm
reviewed
Dec 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersFixes #3894. I don't really have any experience with macOS-related programming, so not really sure if it is technically correct but it does seem to work properly