Windows: Increase border size in undecorated shadow mode for better grip #4181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the border size to make it easier to grip the window.
kchibisov
reviewed
Apr 6, 2025
Comment on lines
1112
to
1114
| params.rgrc[0].bottom -= 2; | ||
| params.rgrc[0].left += 2; | ||
| params.rgrc[0].right -= 2; |
Member
There was a problem hiding this comment.
in which coordinates it is? logical or physical? I'd assume you generally want to apply scaling for it.
Author
There was a problem hiding this comment.
The adjustments might be using logical coordinates. Should I adapt them for DPI scaling?
Member
There was a problem hiding this comment.
The point is that if you have DPR 2, the area where you can grip should match logically if you had DPR 1, otherwise on high DPI monitor you won't be able to grab anything.
Author
There was a problem hiding this comment.
Got it. I'll try adding DPI scaling tomorrow and test it on a high-DPI monitor (if I can find one).
Member
There was a problem hiding this comment.
Just change settings in windows to scale.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enabling undecorated shadow on Windows, the borders, except for the top, become very thin, making dragging the window difficult.
I have modified the border size to make it easier to grab and drag. However, I've realized that this might not be the best solution.
changelogmodule if knowledge of this change could be valuable to users