Skip to content

Enable callback for new command #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Enable callback for new command #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9521b65
Enable callback for new command
Meziu Mar 17, 2025
107902e
Bump CI oldest nightly
Meziu Mar 17, 2025
8e8309b
Bump CI minimum nightly
Meziu Mar 17, 2025
8ff88a9
Bump CI minimum nightly
Meziu Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
matrix:
toolchain:
# Oldest supported nightly
- nightly-2024-03-10
- nightly-2024-09-01
- nightly

continue-on-error: ${{ matrix.toolchain == 'nightly' }}
Expand Down
1 change: 1 addition & 0 deletions src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@
Self::Build(cmd) => Some(cmd),
Self::Run(cmd) => Some(cmd),
Self::Test(cmd) => Some(cmd),
Self::New(cmd) => Some(cmd),
_ => None,
}
}
Expand Down Expand Up @@ -508,7 +509,7 @@
}

// `cargo config get` exits zero if the config exists, or nonzero otherwise
cmd.status().map_or(false, |status| status.success())

Check warning on line 512 in src/command.rs

View workflow job for this annotation

GitHub Actions / lint (stable) 

this `map_or` can be simplified
});

if self.build_args.verbose {
Expand Down
Loading