Skip to content

Use artifact.test to determine if an executable is a test one #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025
Merged

Use artifact.test to determine if an executable is a test one #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ pub(crate) fn get_artifact_config(package: Package, artifact: Artifact) -> CTRCo
// For now, assume a single "kind" per artifact. It seems to be the case
// when a single executable is built anyway but maybe not in all cases.
let name = match artifact.target.kind[0].as_ref() {
"bin" | "lib" | "rlib" | "dylib" if artifact.target.test => {
"bin" | "lib" | "rlib" | "dylib" if artifact.profile.test => {
Copy link
Member

@ian-h-chamberlain ian-h-chamberlain Mar 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me; the cargo_metadata docs are a little unclear (to me) about the difference but I guess Whether or not this target is tested by default by cargo test would in fact be true for most lib targets so I'm surprised I never noticed this before... I guess because we don't generally build .3dsx for libs

Copy link
Contributor Author

@DCNick3 DCNick3 Mar 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to also be true for binaries (or, at least, my binary), so I do wonder how it was never caught before!

format!("{} tests", artifact.target.name)
}
"example" => {
Expand Down
Loading