Add helper type for writing to UTF-16 buffers #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FenrirWolf
force-pushed
the
utf16_writer
branch
2 times, most recently
from
bec11e7 to
4bc7f4d
Compare
We should be able to get by with the text-handling functions from `std`
FenrirWolf
force-pushed
the
utf16_writer
branch
from
4bc7f4d to
4a08920
Compare
Member
Author
|
Okay, I think I'm done making changes to this branch now and it should be good to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the new UTF-16 handling code from #231 and applies it everywhere in
ctru-rsas well as exposing a new public API. It even handles nul-termination properly this time, so that's neat too!#231 should probably be merged before this one, after which I can rebase and remove the redundant
ErrorConfWritercode.