-
Notifications
You must be signed in to change notification settings - Fork 38
Prepare 1.12.0 release #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Yeah -- so apparently this is a major change, so I guess we can't just add it like this. And I think it's also probably not worth doing a 2.0 only for this? |
Yeah I'm afraid this alone doesn't motivate a 2.0 for me :( For now we could keep the Zeroize impls, and downstream users can write |
So one goal in this PR was to avoid having zeroize types/traits in the public API. Do you think we should allow those in order to enable the use of stuff like |
On the assumption we don't want zeroize in the public API, I think the latter is the best way to go -- specifically provide some zeroizing newtypes (maybe generic) that hold a |
|
Release notes
Zeroize
for private key types