pll: add default value for PllDdrControl and PllPeri0Control registers#17
Merged
luojia65 merged 1 commit intorustsbi:mainfrom Nov 9, 2024
Merged
pll: add default value for PllDdrControl and PllPeri0Control registers#17luojia65 merged 1 commit intorustsbi:mainfrom
PllDdrControl and PllPeri0Control registers#17luojia65 merged 1 commit intorustsbi:mainfrom
Conversation
Add impl `Default` for both structs `PllDdrControl` and `PllPeri0Control`, which returns the different default values: - The default value for `PllDdrControl` is `0x4800_2301`. - The default value for `PllPeri0Control` is `0x4821_6300`. Add unit tests for above two default values using related register functions. Signed-off-by: DongQing <[email protected]>
Placebo27
changed the title
PllDdrControl and PllPeri0Control registers
luojia65
approved these changes
Nov 9, 2024
Member
luojia65
left a comment
luojia65
left a comment
There was a problem hiding this comment.
I can confirm that the unit test values matches the Allwinner D1 User Manual, Version 1.0, Section 3.2.6.2 to 3.2.6.3. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add impl
Defaultfor both structsPllDdrControlandPllPeri0Control, which returns the different default values:PllDdrControlis0x4800_2301.PllPeri0Controlis0x4821_6300.Add unit tests for above two default values using related register functions.