Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notices for trust-dns #1806

Merged
merged 1 commit into from
Mar 23, 2025
Merged

Add notices for trust-dns #1806

merged 1 commit into from
Mar 23, 2025

Conversation

thomaseizinger
Copy link
Contributor

Resolves: #1804.

@thomaseizinger thomaseizinger mentioned this pull request Oct 18, 2023
Closed
@thomaseizinger thomaseizinger force-pushed the feat/trust-dns-rebranding branch from 1be0456 to af6c870 Compare October 18, 2023 02:08
@bluejekyll
Copy link
Contributor

I'm not sure I agree completely with this. We're discussing in the hickory-dns repos (formerly trust-dns), I'd like to come to a consensus there before publishing an advisory like this.

@bluejekyll bluejekyll mentioned this pull request Oct 18, 2023
Closed
bluejekyll
bluejekyll suggested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@bluejekyll bluejekyll left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure we want to publish this, but it's missing a note on trust-dns-util as well, which is now hickory-util

Also, maybe add this issue as a reference? hickory-dns/hickory-dns#2051

references = ["https://github.com/hickory-dns/hickory-dns/issues/2051"]

@thomaseizinger
Copy link
Contributor Author

Also, maybe add this issue as a reference? hickory-dns/hickory-dns#2051

I'll add it once there is consensus that these will be published :)

bluejekyll
bluejekyll approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@bluejekyll bluejekyll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I agree with the filing. Thank you for working with us at the project to come to a decent resolution on this @thomaseizinger, I really appreciate your time and effort on this.

@thomaseizinger
Copy link
Contributor Author

This looks good to me, and I agree with the filing. Thank you for working with us at the project to come to a decent resolution on this @thomaseizinger, I really appreciate your time and effort on this.

You are welcome, thank you for collaborating on it! :)

@pinkforest
Copy link
Contributor

pinkforest commented Dec 6, 2023 •
edited
Loading

Multi-crate projects have been typically dealt by adding an advisory around a root crate lightning up all downstream.

It seems trust-dns-proto is dependency of trust-dns-server, trust-dns-client, trust-dns-resolver, trust-dns

For precedent see. git/gix rename via PR/1644 and rusoto via PR/1494

Also given the old crates will not be maintained (assuming here) these have gone past as unmaintained type.

@thomaseizinger
Copy link
Contributor Author

I don't mind either way, happy to remove all but trust-dns-proto!

@djc
Copy link
Contributor

djc commented Dec 4, 2024

I don't mind either way, happy to remove all but trust-dns-proto!

I think that would make sense.

Probably makes sense to move this forward at this point?

@kornelski
Copy link
Contributor

I think it's okay to merge as-is. It has version limit as requested by upstream, and these crates haven't been touched for a year now, so they really are unmaintained.

@djc
Copy link
Contributor

djc commented Dec 20, 2024

Maintainers (@Shnatsel?), how can we move this forward? I'd like to get it released.

@djc
Copy link
Contributor

djc commented Mar 22, 2025

@thomaseizinger I'm a maintainer now -- would you be willing to squash this down to a single advisory for trust-dns-proto only, dated today/some time recent? Then I can get this merged.

@thomaseizinger
Copy link
Contributor Author

@thomaseizinger I'm a maintainer now -- would you be willing to squash this down to a single advisory for trust-dns-proto only, dated today/some time recent? Then I can get this merged.

Yep, can do tomorrow! trust-dns-proto is the root crate I guess? So that will generate a notice for everyone?

@djc
Copy link
Contributor

djc commented Mar 22, 2025

@thomaseizinger I'm a maintainer now -- would you be willing to squash this down to a single advisory for trust-dns-proto only, dated today/some time recent? Then I can get this merged.

Yep, can do tomorrow! trust-dns-proto is the root crate I guess? So that will generate a notice for everyone?

Yes, that's the idea.

@thomaseizinger thomaseizinger force-pushed the feat/trust-dns-rebranding branch from af3c55e to 2b92efb Compare March 23, 2025 05:03
@thomaseizinger
Copy link
Contributor Author

@djc Done!

@djc djc merged commit f044fff into rustsec:main Mar 23, 2025
1 check passed
@djc
Copy link
Contributor

djc commented Mar 23, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kornelski kornelski kornelski approved these changes

@djc djc djc approved these changes

@bluejekyll bluejekyll bluejekyll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trust-dns has rebranded to hickory-dns
5 participants
@thomaseizinger @bluejekyll @pinkforest @djc @kornelski