Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advisory for Stack-buffer-overflow in xmas-elf #2235

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nyw0102
Copy link
Contributor

@nyw0102 nyw0102 commented Mar 3, 2025

No description provided.

@alex
Copy link
Member

alex commented Mar 3, 2025

However, it is still vulnerable because "bucket_count" which stands for the size of hashtable and offset value of the hashtable can be manipulated by users

This doesn't look true? https://github.com/nrc/xmas-elf/blob/master/src/hash.rs#L6-L10 none of these fields are pub.

Is there some other way that users can control the values of these fields?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants