Add advisory for capnp unsoundness #2543
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does this need to be updated to point to 0.25.0 as the fixing version? |
Contributor
|
0.24.0 fixes the issue, but at the cost of adding 0.25.0 removes the need for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unsoundness issue has been verified and patched in the latest version of crate: capnproto/capnproto-rust#605
I would like to confirm for the maintainer that whether the advisory will break any normal use cases.
From my understanding, this will only alarm in the
cargo auditso it might not be bothering. Also, the users of the crate should still be notified the potential UB can be triggered with the safe function in affected versions.